Skip to content

Fix buffer validation message#9131

Merged
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
norbertcyran:fix-buffers-validation-msg
Jan 29, 2026
Merged

Fix buffer validation message#9131
k8s-ci-robot merged 1 commit intokubernetes:masterfrom
norbertcyran:fix-buffers-validation-msg

Conversation

@norbertcyran
Copy link
Copy Markdown
Contributor

@norbertcyran norbertcyran commented Jan 27, 2026

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR fixes a misleading validation message returned by a validation rule checking that PodTemplateRef and ScalableRef in the CapacityBuffer spec are not set together.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Fixed misleading validation message returned when PodTemplateRef and ScalableRef are set together in CapacityBuffer's spec.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@norbertcyran
Fix buffer validation message
91eec20 
This commit fixes a misleading validation message returned by a
validation rule checking that PodTemplateRef and ScalableRef in the
CapacityBuffer spec are not set together.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jan 27, 2026
@k8s-ci-robot k8s-ci-robot added area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2026
@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 27, 2026

Hi @norbertcyran. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed do-not-merge/needs-area Indicates that a PR should not merge because it lacks an area label. labels Jan 27, 2026
@norbertcyran
Copy link
Copy Markdown
Contributor Author

norbertcyran commented Jan 27, 2026

/assign abdelrahman882 BigDarkClown

elmiko
elmiko reviewed Jan 27, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@elmiko elmiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 27, 2026
@elmiko
Copy link
Copy Markdown
Contributor

elmiko commented Jan 27, 2026

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 27, 2026
@towca
Copy link
Copy Markdown
Collaborator

towca commented Jan 29, 2026

/approve

@k8s-ci-robot
Copy link
Copy Markdown
Contributor

k8s-ci-robot commented Jan 29, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: norbertcyran, towca

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 29, 2026
@k8s-ci-robot k8s-ci-robot merged commit d6773ee into kubernetes:master Jan 29, 2026
8 checks passed
@jackfrancis
Copy link
Copy Markdown
Contributor

jackfrancis commented Jan 30, 2026

/cherry-pick cluster-autoscaler-release-1.35

@k8s-infra-cherrypick-robot
Copy link
Copy Markdown

k8s-infra-cherrypick-robot commented Jan 30, 2026

@jackfrancis: new pull request created: #9152

Details

In response to this:

/cherry-pick cluster-autoscaler-release-1.35

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 30, 2026
Merged
@norbertcyran norbertcyran deleted the fix-buffers-validation-msg branch February 5, 2026 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vadasambar vadasambar Awaiting requested review from vadasambar

1 more reviewer

@elmiko elmiko elmiko left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@elmiko elmiko

@BigDarkClown BigDarkClown

@abdelrahman882 abdelrahman882

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cluster-autoscaler Issues or PRs related to the Cluster Autoscaler component cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@norbertcyran @k8s-ci-robot @elmiko @towca @jackfrancis @k8s-infra-cherrypick-robot @BigDarkClown @abdelrahman882